IsDataclass type

[FBruzzesi]

I would be happy to work on IsDataclass (related to #3).

Before starting I have a few questions:

• Should it be in the _other module?
• Any drawback in using dataclasses.is_dataclass?
• I think it would be good to have the option to distinguish between class definition and instance, but glad to get a feedback on this.

[samuelcolvin]

Yes please, module up to you.

dataclasses.is_dataclass should be fine.

If you want IsDataClassType I think that should be a separate type, but you could add it at the same time.

Another question, should IsDataclass look at fields, so you can do IsDataclass(foo=4, bar=5)? Then do we need IsPartialDataclass?

[FBruzzesi]

If you want IsDataClassType I think that should be a separate type, but you could add it at the same time.

I had in mind an argument for it, but I guess having a different class itself is much more explicit.

Another question, should IsDataclass look at fields, so you can do IsDataclass(foo=4, bar=5)? Then do we need IsPartialDataclass?

Wouldn't this just come down to the following check(s)?

from dirty_equals import IsDict, IsPartialDict

instance.__dict__ == IsDict(foo=4, bar=5)
# or 
instance.__dict__ == IsPartialDict(foo=4)

[samuelcolvin]

Or HasAttributes, still I think it would be a useful addition.

[FBruzzesi]

What do you think about the following case:

@dataclass
class Foo:
    a: int
    b: int

foo = Foo(a=1, b=2)

foo == IsDataclass # -> True
foo == IsDataclass(a=1, b=2) # -> True
foo == IsDataclass(a=1) # -> False

foo == IsDataclass() # -> ???

(Current implementation I have makes it True)