-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more resolver options #19
base: main
Are you sure you want to change the base?
Conversation
I did also take a look at more drastic changes, to fit some of my needs: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 97.54% 91.07% -6.48%
==========================================
Files 4 5 +1
Lines 204 269 +65
Branches 37 62 +25
==========================================
+ Hits 199 245 +46
- Misses 3 12 +9
- Partials 2 12 +10
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Was able to run the workflow on my fork and passing for this branch now |
Some modifications to allow more resolver options, either by providing a resolver or multiple upstream servers.
Passed the tests, but maybe add more tests to check for multiple upstream resolvers or other desired configurations.
Added checks for modifying records by using a lock.
One main RecordsResolver to keep all the records logic in one place
Created a RoundRobinResolver to iterate through multiple resolvers until a answer is found
Allow listening in multiple ports