Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more resolver options #19

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

jose-pr
Copy link

@jose-pr jose-pr commented Oct 21, 2023

Some modifications to allow more resolver options, either by providing a resolver or multiple upstream servers.
Passed the tests, but maybe add more tests to check for multiple upstream resolvers or other desired configurations.
Added checks for modifying records by using a lock.
One main RecordsResolver to keep all the records logic in one place
Created a RoundRobinResolver to iterate through multiple resolvers until a answer is found
Allow listening in multiple ports

@jose-pr
Copy link
Author

jose-pr commented Oct 22, 2023

I did also take a look at more drastic changes, to fit some of my needs:
https://github.com/jose-pr/dnserver/tree/reorg
It mainly stays the same api but expands on configuration options and on better support for custom resolvers.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #19 (c973193) into main (a99dfe9) will decrease coverage by 6.48%.
The diff coverage is 84.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   97.54%   91.07%   -6.48%     
==========================================
  Files           4        5       +1     
  Lines         204      269      +65     
  Branches       37       62      +25     
==========================================
+ Hits          199      245      +46     
- Misses          3       12       +9     
- Partials        2       12      +10     
Files Coverage Δ
dnserver/main.py 88.50% <84.42%> (-10.62%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99dfe9...c973193. Read the comment docs.

@jose-pr
Copy link
Author

jose-pr commented Oct 22, 2023

Was able to run the workflow on my fork and passing for this branch now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant