-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted i18n gem to version 0.8.1 #1184
Conversation
Changes Unknown when pulling 0484443 on smithjp:1-7-7-release into ** on samvera:1-7-7-release**. |
Can you provide a replication case for the bug? Have you filed an issue with the maintainers of the i18n gem? |
Was it this issue? CanCanCommunity/cancancan#415 |
The test failures look like this:
Which can be seen in the automated tests for previous pull request at: https://travis-ci.org/samvera/curation_concerns/jobs/240798479. |
@smithjp to me it looks like the problem is on this line: https://github.com/samvera/curation_concerns/blob/master/app/renderers/curation_concerns/renderers/configured_microdata.rb#L13 The default probably shouldn't be |
I think I see what is happening here: When you say I made an upstream issue: ruby-i18n/i18n#379 Please add a comment next to your change that points to that issue. That way we can back out your change when the issue is resolved upstream. |
I have added a comment in the Gemfile.extra file. Is this ok? |
Changes Unknown when pulling 594d84e on smithjp:1-7-7-release into ** on samvera:1-7-7-release**. |
Changes Unknown when pulling 594d84e on smithjp:1-7-7-release into ** on samvera:1-7-7-release**. |
Fixes test failures due to missing translations.
It appears that the curation_concerns gem is not compatible with i18n gem >= 0.8.3, so an explicit dependency for i18n version 0.8.1 is being added.
@samvera/sufia-code-reviewers