Allows the File Set Show page to display. #1476
Conversation
|
@hectorcorrea Not sure if this helps document/break down your TODOs, but you can construct task lists in GitHub comments like so:
(It's also cool to have TODOs in code comments, naturally.) |
| @@ -15,12 +15,20 @@ def render_collection_list(fs) | |||
| end | |||
|
|
|||
| def display_multiple(value) | |||
| auto_link(value.join(" | ")) | |||
| # TODO: figure out why sometimes we get an string and some others an array | |||
There was a problem hiding this comment.
This is a good TODO to leave in. I think the next few lines of code are a good candidate to take a "tell, don't ask" approach. Like so:
string_value = Array(value).join(" | ")
auto_link(string_value)There was a problem hiding this comment.
No changes were needed to this method after all.
|
Looking good so far, @hectorcorrea! Left some comments about the nitty-gritties. |
hectorcorrea
force-pushed
the
file_set_show
branch
from
8c2bed3
to
9ddf8fd
Compare
|
This is ready to merge. Missing items have been entered as new tickets (See links above) |
| @@ -15,16 +15,16 @@ def render_collection_list(fs) | |||
| end | |||
|
|
|||
| def display_multiple(value) | |||
| auto_link(value.join(" | ")) | |||
| auto_link(value) | |||
There was a problem hiding this comment.
hum...hold on one sec. I shouldn't have changed this. Resubmitting in a second.
hectorcorrea
force-pushed
the
file_set_show
branch
from
9ddf8fd
to
38391f4
Compare
| <p class="genericfile_description"><%= display_multiple @presenter.description %></p> | ||
| <%= render 'show_descriptions' %> |
There was a problem hiding this comment.
Are you deleting this because there's currently no way to edit the descriptions that would be shown here? If so, I'd say we should use <%# TODO: render 'show_descriptions' %> instead, since there are discussions about allowing FileSet descriptions in Sufia 7. (If not in the 7.0.0 release.)
|
Hi @hectorcorrea, I have just one outstanding question about a partial rendering deleted in the FS show view. |
…cket in GitHub. Fixes #1464
hectorcorrea
force-pushed
the
file_set_show
branch
from
38391f4
to
53efced
Compare
Allows the File Set Show page to display.
There are still several TODOs that need to be addressed. Fixes #1464
This is how it looks so far.
