Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix logic for displaying custom alt text #121

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

kirkkwang
Copy link
Contributor

This is a rework for displaying the custom alt text for works in the dashboard. Also the fallback for the text is now aligned with Hyrax

https://github.com/samvera/hyrax/blob/cbdc3194b45d623e68467bca244df2831924d0a7/app/views/hyrax/my/works/_list_works.html.erb#L12

Pasted image 20230727091111 image

This is a rework for displaying the custom alt text for works in the
dashboard.
@ShanaLMoore
Copy link
Collaborator

ShanaLMoore commented Jul 27, 2023

Should this include the required changes for collection index? @kirkkwang

@kirkkwang
Copy link
Contributor Author

@ShanaLMoore This does not, that was actually in the Hyku app itself.

@ShanaLMoore
Copy link
Collaborator

@ShanaLMoore This does not, that was actually in the Hyku app itself.

Oh ok. I think this PR should include a fix for that too. Will a partial override work?

@kirkkwang
Copy link
Contributor Author

@ShanaLMoore This does not, that was actually in the Hyku app itself.

Oh ok. I think this PR should include a fix for that too. Will a partial override work?

Hmm, there currently isn't a list_collections partial in AllinsonFlex, I thought that this gem didn't even affect Collections.

Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kirkkwang I didn't realize I was reviewing an allinson flex PR 🙈 I've had a busy meeting filled morning and must not have been paying attention to the context. It totally makes sense now to not have collection work here.

@kirkkwang kirkkwang merged commit 72e2cbe into main Jul 27, 2023
@kirkkwang kirkkwang deleted the list-works-partial-rework branch July 27, 2023 19:50
kirkkwang added a commit to scientist-softserv/utk-hyku that referenced this pull request Jul 27, 2023
This commit will fix the alt text for the collection thumbnail on the
dashboard and the Allinson Flex update will fix the thumbnail for the
work on the dashboard.

Ref:
  - samvera-labs/allinson_flex#121
  - #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants