Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Move "|" button separator to be within conditional #822

Merged
merged 1 commit into from
Jun 30, 2023
Merged

🐛 Move "|" button separator to be within conditional #822

merged 1 commit into from
Jun 30, 2023

Conversation

bkiahstroud
Copy link
Contributor

Follow up to:

Only render button separator when needed

@bkiahstroud bkiahstroud added the ignore-for-release ignore this for release notes label Jun 29, 2023
ShanaLMoore
ShanaLMoore approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before

image

after

when SHOW_CREATE_AND_VALIDATE is not defined:

Screenshot 2023-06-30 at 09-46-14 New Importer __ Hyku

when SHOW_CREATE_AND_VALIDATE is true:

Screenshot 2023-06-30 at 09-48-39 New Importer __ Hyku

@bkiahstroud bkiahstroud merged commit e6f2cf9 into main Jun 30, 2023
7 checks passed
@bkiahstroud bkiahstroud deleted the its-my-ocd branch June 30, 2023 16:59
@DeonFranklin DeonFranklin mentioned this pull request Jul 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShanaLMoore ShanaLMoore ShanaLMoore approved these changes

@DeonFranklin DeonFranklin Awaiting requested review from DeonFranklin

Assignees
No one assigned
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkiahstroud @ShanaLMoore