Re-enables nav-tabs for hydra apps #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sephirothkod
approved these changes
Jul 17, 2023
kirkkwang
added a commit
that referenced
this pull request
Jul 20, 2023
This commit will alter the install generator to move the require for bulkrax/application above dataTables require. This was causing jquery errors in Hyku applications because of recent changes. Ref: - #836
kirkkwang
added a commit
to scientist-softserv/utk-hyku
that referenced
this pull request
Jul 20, 2023
This commit will update the revisions of `Bulkrax` and `AllinsonFlex` to the latest versions to bring in the views changes for the admin dashboard sidebar. Also, this commit moves the js require for Bulkrax up above the dataTables require to fix the issue with the admin jquery throwing errors. This was likely due to a recent change to make Bulkrax work better with Hydra. Ref: - samvera/bulkrax#836 - samvera-labs/allinson_flex#120 - samvera/bulkrax#838
kirkkwang
added a commit
to scientist-softserv/utk-hyku
that referenced
this pull request
Jul 21, 2023
This commit will update the revisions of `Bulkrax` and `AllinsonFlex` to the latest versions to bring in the views changes for the admin dashboard sidebar. Also, this commit moves the js require for Bulkrax up above the jQuery requires to fix the issue with the admin jQuery throwing errors. This was likely due to a recent change to make Bulkrax work better with Hydra. Ref: - samvera/bulkrax#836 - samvera-labs/allinson_flex#120 - samvera/bulkrax#838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//= require bulkrax/application)above the require statements for the dataTables javascript (//= require dataTables/jquery.dataTables //= require dataTables/bootstrap/3/jquery.dataTables.bootstrap) in their localapplication.js. This has since been updated in the generator for bulkrax so it will be in the correct place for future installations.Summary
Bootstrap's javascript files were not included by default and bulkrax was relying on the parent application for some of its js to work.
this PR includes bootstrap (and jquery dependency), makes sure they all load in the same order, and activates the nav tabs on the importer/show page.
likely reason the tabs need to be initialized separately in this case
Bootstrap's JavaScript components, including the tabs functionality, require manual initialization in certain cases. This is because the default behavior of Bootstrap's JavaScript is to automatically initialize the components on page load. However, when using frameworks like Turbolinks or loading content dynamically, the JavaScript initialization may not occur automatically.In your case, since you mentioned that you are working within a Rails gem, which is inside another Rails project, it's possible that the application's JavaScript files are not being loaded or initialized correctly due to the structure of the project or the usage of Turbolinks.
By explicitly adding the JavaScript initialization code, you ensure that the tab functionality is properly triggered when the page is loaded or when the tab links are clicked. This approach bypasses any potential conflicts or issues that may be preventing the automatic initialization.
So, while Bootstrap's tabs.js file is present in your app, adding the initialization code manually guarantees that the tab functionality is consistently applied, regardless of the project's structure or other factors that may affect the automatic initialization.
It's worth noting that Bootstrap's JavaScript components are designed to be flexible and work with different frameworks and setups. This means that manual initialization may be necessary in certain scenarios to ensure proper functionality.
Related
scientist-softserv/west-virginia-university#82
Acceptance Criteria
Videos
Before: https://share.getcloudapp.com/E0uLgQL9
After: https://share.getcloudapp.com/E0uLgQR9