🐛 Fix importers sorting for last run and next run

[kirkkwang]

Summary

🐛 Fix importers sorting for last run and next run

7d985dd

This commit will fix the sorting error that happens when the user is on
the importers index and attempts to sort by the last run or next run. We
add some migrations to add fields that the datatables can use so it can
sort properly. Previously, this was not working because the
last_imported_at and next_import_at fields were actually methods on the
importer_run object and not the importer object. We are adding a few
callbacks to the importer and importer_run models to ensure that the
fields are properly set when they are called from either the web or the
worker.

Ref:

• Sorting importers by "Last Run" brings up a DataTables alert, does not change order. #956

Zight.Recording.2024-09-16.at.16.43.37.mp4

🤖 Update upload-artifact and download-artifact

aca33e5

CI was getting errors because the versions we were previously using were
deprecated. This commit updates the actions to the latest versions.

🐛 Remove Downloadable Files sorting

d4d4749

The downloadable files sorting was broken plus, it's not clear now a
downloadable file should be sorted.

⚙️ Add guard for new migrations

7011d72

This commit will add a guard to the new migrations to ensure that they
do not run if the columns already exist in the database.

Note

To get the changes all the Importers need to be updated, something like:

Importers.all.each(&:save)

[ShanaLMoore]

Exporters were also reported with the same issue. Is there an exporter table we need to add a migration to as well?

[kirkkwang]

@ShanaLMoore thanks for checking on that. The only issue I saw was the downloadable files sorting, it was broken, but I'm just taking it out since no one was using it. It's not clear to me how to sort that column anyways. Number of files? Date? etc. If there's demand for this feature then I think we can figure something out later.

[ShanaLMoore]

Sounds good. My other question is for existing application data. In addition to the migration, how are we handling existing importers to populate those fields? And would we need to for the sort to work properly? Perhaps a rake task is needed?

[kirkkwang]

@ShanaLMoore We just need to update all the Importers and the changes will get applied.

[ShanaLMoore]

right, so maybe we should add a rake task to the migration to accomplish this? vs relying on the dev to remember to do.

[kirkkwang]

@ShanaLMoore ah okay, that's a good idea. So how would that look like? The dev has to run migrations, and then migration automatically runs the rake task?

[ShanaLMoore]

Yes, I'll try to find an example. LaRita has set this up before somewhere.

update: scratch the above approach. After discussion we will...

Add a rake task to re save all importers and/or add the command to release notes. cc @kirkkwang