Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures that more complex Devise routes are not broken by the insertion of mount Hydra::RoleManagement::Engine => '/' #33

Merged
merged 2 commits into from
May 10, 2018
Merged

Ensures that more complex Devise routes are not broken by the insertion of mount Hydra::RoleManagement::Engine => '/' #33

merged 2 commits into from
May 10, 2018

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #9

@jrgriffiniii
Ensures that more complex Devise routes are not broken by the inserti…
50ec970 
…on of mount Hydra::RoleManagement::Engine => '/'
@coveralls
Copy link

coveralls commented May 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.66% when pulling 97ece23 on jrgriffiniii:issues-9-jrgriffiniii-routes into d552bb7 on samvera:master.

coblej
coblej previously approved these changes May 9, 2018
View reviewed changes
Copy link

@coblej coblej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure the '?' is necessary in this case but I don't think it is harmful (and I'm far from an expert on regular expressions).

@jrgriffiniii jrgriffiniii merged commit a474121 into samvera:master May 10, 2018
@jrgriffiniii jrgriffiniii deleted the issues-9-jrgriffiniii-routes branch May 10, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coblej coblej coblej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrgriffiniii @coveralls @coblej