Integrating Bixby and RuboCop #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
force-pushed
the
issues-34-jrgriffiniii-rubocop
branch
from
087e294
to
72fc376
Compare
jrgriffiniii
changed the title
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-34-jrgriffiniii-rubocop
branch
from
622dbee
to
b31919b
Compare
Downgrading the `json` Gem version for supporting Rails 4.x releases; Updating engine_cart to 2.0.1; Testing against Ruby releases 2.4.3 and 2.5.0; Fixing test cases for Hydra::RoleManagement.draw_routes; Removing support for Rails releases 4.2.10 and earlier (given that engine_cart app. generation fails for Blacklight releases beyond 6.9.0)
jrgriffiniii
force-pushed
the
issues-34-jrgriffiniii-rubocop
branch
from
b31919b
to
758dbfb
Compare
jrgriffiniii
changed the title
tpendragon
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34 (but removes support for Rails 3.x releases, which is no longer officially supported by the Rails community: http://guides.rubyonrails.org/maintenance_policy.html)