Integrates CircleCI for continuous integration #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecating Travis CI as a continuous integration service
jrgriffiniii
force-pushed
the
issues-44-jrgriffiniii-circleci
branch
from
9bb7079
to
af1becd
Compare
|
@jrgriffiniii Why the complicated workflow? Are we getting something from separating bundle/lint from everything else? |
jrgriffiniii
force-pushed
the
issues-44-jrgriffiniii-circleci
branch
from
5637066
to
ad38431
Compare
|
Since this gem requires an engine cart generate and multiple ruby versions being tested, I think it makes sense to have a separate build (bundle, lint, generate) job from the test jobs. Hyrax separates out the lint step so it can run in parallel to the generate step. I'm not sure if it is really worth it for this gem given it is much smaller than hyrax. |
|
Coveralls didn't report back. Did you add the COVERALLS_REPO_TOKEN to the CircleCI environment variables @jrgriffiniii ? |
jrgriffiniii
force-pushed
the
issues-44-jrgriffiniii-circleci
branch
2 times, most recently
from
e04e444
to
6837910
Compare
jrgriffiniii
force-pushed
the
issues-44-jrgriffiniii-circleci
branch
from
6837910
to
95ce17d
Compare
|
Coveralls is now reporting for this. |
tpendragon
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44