Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 #48

Merged
merged 2 commits into from
May 22, 2019
Merged

Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 #48

merged 2 commits into from
May 22, 2019

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #47

@coveralls
Copy link

coveralls commented May 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 98.928% when pulling 0f538f9 on jrgriffiniii:issues-47-jrgriffiniii-test-rails-ruby-latest into 0a725b4 on samvera:master.

cjcolvar
cjcolvar reviewed May 16, 2019
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the circle configs of other core components, I think collapsing the jobs into one makes the most sense unless there is a reason that I'm missing.

@jrgriffiniii jrgriffiniii changed the title Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 [WIP] Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 May 17, 2019
cjcolvar
cjcolvar approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really clean now!
FWIW it looks like the new version ran ~30s slower but that is only comparing one run of each so maybe not enough to really evaluate the two approaches. The readability of the new approach I think out weighs the small slowdown.

@jrgriffiniii jrgriffiniii changed the title [WIP] Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 Updates the CircleCI configuration to test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6 May 22, 2019
@jrgriffiniii jrgriffiniii merged commit e1bf600 into samvera:master May 22, 2019
@jrgriffiniii jrgriffiniii deleted the issues-47-jrgriffiniii-test-rails-ruby-latest branch May 22, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test against Rails release 5.1.7 and Ruby releases 2.6.3, 2.5.5, and 2.4.6
3 participants
@jrgriffiniii @coveralls @cjcolvar