Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ruby 2.7.z and Rails 6.y.z to the CircleCI build configuration #58

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Adding Ruby 2.7.z and Rails 6.y.z to the CircleCI build configuration #58

merged 3 commits into from
Apr 28, 2020

Conversation

randalldfloyd
Copy link
Contributor

No description provided.

@randalldfloyd randalldfloyd mentioned this pull request Apr 17, 2020
Closed
@jrgriffiniii
Copy link
Contributor

I'm not certain why CircleCI isn't running for this, as the builds should be run for forked pull requests:
image

@jrgriffiniii
Copy link
Contributor

These tests don't appear to be running on https://circleci.com/gh/randalldfloyd/hydra-role-management (or, they were 18 hours ago). Further, on the last commit, there were failing tests.

@jrgriffiniii
Copy link
Contributor

CircleCI failed to trigger the build given some internal configuration issues, and this will be resolved.

@jrgriffiniii
Copy link
Contributor

Regarding the RuboCop upgrade and removal of Bixby which I needed to undertake for my own updates, please see samvera/browse-everything@65c6c6a for reference.

@coveralls
Copy link

coveralls commented Apr 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 98.925% when pulling ccb8277 on randalldfloyd:issue-55_ruby-2.7 into b90747e on samvera:master.

@randalldfloyd
Copy link
Contributor Author

@jrgriffiniii Finally got over all my onboarding and got a fully passing PR!

@jeremyf jeremyf merged commit 3969f59 into samvera:master Apr 28, 2020
This was linked to issues Apr 28, 2020
Add support for Rails 6.0.z releases #56
Closed
Add support for Ruby 2.7.z releases #55
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyf jeremyf jeremyf approved these changes

@jrgriffiniii jrgriffiniii Awaiting requested review from jrgriffiniii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Rails 6.0.z releases Add support for Ruby 2.7.z releases
4 participants
@randalldfloyd @jrgriffiniii @coveralls @jeremyf