🐛 Another fix to the solr connection #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we probably need to define our own valkyrie indexing adapter, but this should work as a temporary fix.
laritakr
force-pushed
the
i2177-fix-solr-endpoint
branch
from
ba01ce4
to
73c8e8d
Compare
kirkkwang
approved these changes
Apr 6, 2024
bkiahstroud
added a commit
to scientist-softserv/hykuup_knapsack
that referenced
this pull request
May 16, 2024
We're seeing an issue where some Solr requests are being sent to the wrong tenant. With this Hyku update, we'll get the following fixes related to Solr endpoints: - samvera/hyku#2179 - samvera/hyku#2180 - samvera/hyku#2182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2177
The default connection is called from Valkyrie and is set up incorrectly for Hyku in Hyrax. With this change, the default connection from Hyrax is only ever used during initialization steps so we will always have an appropriate solr URL.
This provides a temporary solution... ideally consider setting up and initializing a Hyku indexing adapter so decorating this is unnecessary.