-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate thumbnails for PDFs #2254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
previously approved these changes
Jun 21, 2024
Test Results 3 files ±0 3 suites ±0 17m 32s ⏱️ -41s Results for commit 3a53fd4. ± Comparison against base commit d700f82. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
When text extraction fails on a PDF, the derivative job resubmits. This was results in 5 Hyrax::FileMetadata objects for the same thumbnail file, because jobs automatically resubmit 5 times. In this PR, I commented out the failing extract_full_text method. I also qualified the thumbnail creation on whether the thumbnail is already there, in cases where we run more after creating the thumbnail.
laritakr
force-pushed
the
file_set_derivatives
branch
from
June 22, 2024 04:08
0ab93fc
to
62dece3
Compare
kirkkwang
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When text extraction fails on a PDF, the derivative job resubmits. This was resulting in 5 Hyrax::FileMetadata objects on a file set, all for the same thumbnail file, because jobs automatically resubmit 5 times.
In this PR, I commented out the failing extract_full_text method, but also qualified the thumbnail creation on whether the thumbnail is already there.
Screenshots
BEFORE
AFTER