-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix Bulkrax issues for Knapsack applications #2259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are removing the bulkrax_identifier opinion because applications should declare their own source identifiers. We are also commenting out the logic for required fields for now, it is not working for Valkyrie objects.
Test Results 3 files ±0 3 suites ±0 17m 37s ⏱️ -21s Results for commit 23c7dd6. ± Comparison against base commit de18ed2. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
This pull request skips 6 tests.
|
ShanaLMoore
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the bulkrax_identifier opinion because applications should declare their own source identifiers. We are also commenting out the logic for required fields for now, it is not working for Valkyrie objects.