-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I769 snippets #2329
Merged
Merged
I769 snippets #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will introduce the Hyku::Indexers::FileSetIndexer to add indexing logic for born digital PDFs when using PDF.js. We also change the works' indexing field to match the file sets' indexing field (all_text_tsimv). We also "valyrized" the logic in the HykuIndexing module to accomplish this. Ref: - scientist-softserv/adventist_knapsack#769
This commit will add logic to add the ability to see search snippets with PDFs that were split through IIIF Print.
This commit will add a simple test for the FileSetIndexer logic to check that the text extraction from a born digital pdf works as expected.
ShanaLMoore
previously approved these changes
Sep 18, 2024
laritakr
requested changes
Sep 18, 2024
Test Results 3 files ±0 3 suites ±0 18m 49s ⏱️ +42s Results for commit 617bc24. ± Comparison against base commit 6ad34e1. This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
ShanaLMoore
reviewed
Sep 18, 2024
This commit will rename the #full_text method to #extract_full_text because it was causing weird issues with super.
ShanaLMoore
approved these changes
Sep 19, 2024
laritakr
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
🎁 Implement all_text searching in Valkyrie for PDF
54bf5d7
This commit will introduce the Hyku::Indexers::FileSetIndexer to add
indexing logic for born digital PDFs when using PDF.js. We also change
the works' indexing field to match the file sets' indexing field
(all_text_tsimv). We also "valyrized" the logic in the HykuIndexing
module to accomplish this.
Ref:
🎁 Add logic for snippets when splitting PDFs
b666d84
This commit will add logic to add the ability to see search snippets
with PDFs that were split through IIIF Print.
✅ Add test for file set indexer logic
9aa21fc
This commit will add a simple test for the FileSetIndexer logic to check
that the text extraction from a born digital pdf works as expected.
Screenshots / Video
With a query term
Without a query term