-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snippets #2362
Fix snippets #2362
Conversation
Test Results 3 files ±0 3 suites ±0 18m 6s ⏱️ +13s Results for commit f40c374. ± Comparison against base commit 6931967. This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
- Refactored generate_work_url method by breaking it into smaller, modular helper methods for readability and maintainability. - Added YARD documentation to each method in SharedSearchHelper for better code clarity and generating documentation.
Not all items were being found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one burning question. The rest looks good.
Issue:
TODO:
when there's a match
when there's no matches