Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snippets #2362

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Fix snippets #2362

merged 9 commits into from
Oct 25, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Oct 21, 2024

Issue:

TODO:

  • uv search params should not search if no highlights exists ✅
  • #render_ocr_snippets should check for highlights and not snippets.blank? ✅
  • When there are no snippets the "keyword matches" label still appears. ✅ (M3) [SHANA]

when there's a match

image

when there's no matches

image image
  • When there is a match, it should highlight the first one. ❌ (prod issue - M3)
  • When there is a match, it also finds more matches than it should. ❌ (prod issue - M3)
  • Thumbnail link does not perform a UV search ✅ (M1) [LARITA]
  • Update Adventist knapsack and make any necessary additional changes (M1)

Copy link

github-actions bot commented Oct 21, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 6s ⏱️ +13s
2 040 tests +2  1 990 ✅ +2  50 💤 ±0  0 ❌ ±0 
2 067 runs  +2  2 015 ✅ +2  52 💤 ±0  0 ❌ ±0 

Results for commit f40c374. ± Comparison against base commit 6931967.

This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5d559a36-0089-4927-b008-cf672a4d481f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 820057f0-e80d-4ad0-91b2-4162b5e0fe81
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4f1f16c6-d28b-4f6d-8530-e52a8834134e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update bbc61d13-9d6e-4b3f-be48-adb79e33b32d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 7619f524-3e21-4701-9990-369416a3e181
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ec04dac2-529a-4abd-98b4-f6587ac8bdcd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8d3f1e9d-50d7-498b-90f2-55e8771c86b6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update cde19569-b75c-4925-852c-9f20a79cf727
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy f4855b6e-1bb0-4608-bbba-10a0ccb45178
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 3041b2c7-ffe0-4344-8faf-c519d056b73c
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 4eb3897f-5a2d-4bb6-8daa-c281588b79eb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d8b40c83-900b-4e3c-9889-d854618fcbbc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cfadf3be-3bb9-437c-a9d6-852d34d1e5d6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1c42f9ba-a409-4654-b2bf-09ed00d736df
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy d7c8afca-27b6-4c00-9355-f7f120d30f9c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6e6c8d56-f892-48df-9ed4-203cbc834161
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read fe241a4d-13e2-4635-beae-7c42e58aef8a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 44881033-e2c5-46cd-8996-adf87bdeadd4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b74c3b79-284f-4195-80d5-a1e82ee40344
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 9a92da01-4685-449b-804d-f15a6cc6743d
…

♻️ This comment has been updated with latest results.

ShanaLMoore and others added 4 commits October 21, 2024 15:48
- Refactored generate_work_url method by breaking it into smaller, modular helper methods for readability and maintainability.
- Added YARD documentation to each method in SharedSearchHelper for better code clarity and generating documentation.
@laritakr laritakr added the patch-ver for release notes label Oct 23, 2024
@laritakr laritakr changed the title WIP Fix snippets Oct 24, 2024
@laritakr laritakr marked this pull request as ready for review October 24, 2024 20:17
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one burning question. The rest looks good.

app/views/catalog/_index_header_list_default.html.erb Outdated Show resolved Hide resolved
@laritakr laritakr merged commit 920da19 into main Oct 25, 2024
8 checks passed
@laritakr laritakr deleted the i769-snippets-rework branch October 25, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants