[i886] - update logic to fix collection thumbnail bug #2381
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files ±0 3 suites ±0 17m 55s ⏱️ +13s For more details on these failures, see this check. Results for commit d0a437f. ± Comparison against base commit 8cf3a6f. This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ShanaLMoore
added
reindex required
patch-ver
laritakr
reviewed
Nov 14, 2024
ShanaLMoore
commented
Nov 14, 2024
laritakr
previously approved these changes
Nov 14, 2024
…athServiceDecorator The default work thumbnail was displaying even though the default collection thumbnail was set. Issue: - scientist-softserv/adventist_knapsack#886 - Updated #call method to use default_collection_image for collection resources when thumbnail_id is blank. - Ensures collections without specific thumbnails use the site-wide default collection image instead of the default work image. - Improved fallback logic to distinguish between collections and works, avoiding issues with collections displaying the work default image.
ShanaLMoore
force-pushed
the
i886-default-collection-thumbnail-bug
branch
from
771c95f
to
7e77eb6
Compare
|
The failing specs gets resolved by updating Hyrax. ref: #2382 |
…orator` - Added a test for `default_collection_image` to verify it returns the site-specific default collection image when available. - Stubbed `Site.instance` to ensure the spec accurately tests behavior when a site default image is present or absent.
laritakr
approved these changes
Nov 14, 2024
NOTESThis was tested in adventist knapsack as well as hyku demo, and it appears to be working. As an aside, locally I was getting this error when trying to set a thumbnail in Adventist knapsack, but the same error happened when using main (of both adventist knapsack and hyku). This error does not occur in staging or prod so I'm not sure what this is about. To reproduce, spin up main Adventist Knapsack. In the submodule check out this branch. Spin the project up, create a collection. Click the branding tab. Upload and save a thumbnail file. 🤔
|
|
the spec and lint failure are coming from main so I'm going to go ahead and merge this |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default work thumbnail was displaying even though the default collection thumbnail was set.
Issue:
When No Collection Branding is Set
When Default Collection Thumbnail is Set
When Default Collection Thumbnail is NOT set
When Collection Branding is Set
When Default Collection Thumbnail is Set