Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to change mapping of required metadata property:keyword #1505

Closed
jenyoung opened this issue Aug 16, 2017 · 9 comments · Fixed by #3748
Closed

Proposal to change mapping of required metadata property:keyword #1505

jenyoung opened this issue Aug 16, 2017 · 9 comments · Fixed by #3748

Comments

@jenyoung
Copy link

Descriptive summary

A discussion in the samvera/metadata slack channel occurred about the current mapping of required field property:keyword to DC11.relation in basic_metadata.rb

Current DC definition of relation is "A related resource."

Rationale

The actual intended usage of keyword (and how most seem to be using it) per discussion in the slack channel is for either keywords or tags. This would still be an uncontrolled vocabulary field and separate from subject.

Further investigation by the Samvera Metadata IG led to a discussion during our July call about changing the mapping to SCHEMA:keywords instead.

Changing the default mapping of keyword would also enable those who wish to use a relation-type property to do so correctly without have to alter the default.

Proposal

Change: property :keyword, predicate: ::RDF::Vocab::DC11.relation

to: property :keyword, predicate: ::RDF::Vocab::SCHEMA.keywords

If accepted, http://www.schema.org would also need to be added to the list of namespaces.

I'm also tagging @samvera/hyrax-metadataists for any feedback.

@ghost
Copy link

ghost commented Aug 17, 2017

I support this. We would need to create a migration task for existing data (see recent discussion of changing isPartOf #1461).

@jlhardes
Copy link
Contributor

I also think this is a good change to make and worth the migration task to adjust current instances. schema:keywords is a more accurate property and sets things up better for Hyrax use out of the box.

@mjgiarlo
Copy link
Member

(And I believe ::RDF::Vocab::SCHEMA is already available: https://github.com/ruby-rdf/rdf-vocab/blob/develop/lib/rdf/vocab/schema.rb)

@jenyoung
Copy link
Author

I can't add labels (which is ok) but what is the next step to move this forward? Thanks!

@ghost
Copy link

ghost commented Aug 29, 2017

I think @mjgiarlo would be the person to add labels. I should have some time in a couple of weeks to take a look at this. The change is easy, but I need to put some thought into the migration.

@mjgiarlo
Copy link
Member

Hi! I added some labels. LMK if I got the right ones.

@ghost
Copy link

ghost commented Sep 12, 2017

Just having a think about how to approach migrating data when the predicate changes, I have come up with the following idea (with some inspiration from #1461) ... I am open to better ways of approaching this!

  • change the predicate for keyword (this will effectively orphan existing data in fedora and make it inaccessible to hyrax)
  • to mitigate ☝️ add a legacy_keyword property using the old predicate so that the existing data is not lost
  • create a rake task to migrate all old data to the new property/predicate
  • add a deprecation warning that the legacy field will be removed in version xxx with a note about running the task

ghost pushed a commit to samvera-labs/dog_biscuits that referenced this issue Sep 18, 2017
ghost pushed a commit to samvera-labs/dog_biscuits that referenced this issue Sep 20, 2017
made skos:note a common property

change origin_date from single to multiple

change date published from single to multiple

change single properties to multiple used for thesis, published item, conference item (all works except dataset and package).

change keyword to use ::RDF::Vocab::SCHEMA.keywords as per samvera/hyrax#1505
ghost pushed a commit to samvera-labs/dog_biscuits that referenced this issue Sep 20, 2017
add ExtendedSolrDocument concern; made skos:note a common property;
change origin_date from single to multiple; change date published from
single to multiple; change single properties to multiple used for
thesis, published item, conference item (all works except dataset and
package); change keyword to use ::RDF::Vocab::SCHEMA.keywords as per samvera/hyrax#1505
@jenyoung
Copy link
Author

jenyoung commented Oct 4, 2017

@geekscruff This sounds like a good plan forward. I'd argue against orphaning the existing data. How do we make this happen? Thanks!

@ruthtillman
Copy link
Contributor

Just re-upping that this issue is endorsed by the metadata IG in our review of Hyrax basic metadata fields. Note that in data migration, schema:keywords is a comma-separated list whereas the current dc:relation is a repeating field.

@no-reply no-reply modified the milestones: Backlog, 3.x series Feb 22, 2019
@ghost ghost self-assigned this Apr 15, 2019
ghost pushed a commit that referenced this issue Apr 15, 2019
ghost pushed a commit that referenced this issue Apr 15, 2019
ghost pushed a commit that referenced this issue Apr 16, 2019
ghost pushed a commit that referenced this issue Apr 16, 2019
ghost pushed a commit that referenced this issue Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants