Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Set and Collection participants tab layouts are inconsistent #3365

Closed
cjcolvar opened this issue Nov 1, 2018 · 1 comment
Closed
Assignees

Comments

@cjcolvar
Copy link
Member

cjcolvar commented Nov 1, 2018

Descriptive summary

Remove buttons for collection participants are not consistent between the disabled "Repository Managers" and user added users and groups. Note how the disabled one is missing the padding.

screen shot 2018-11-01 at 10 55 14 am

It looks like this CSS is to blame: https://github.com/samvera/hyrax/blob/master/app/assets/stylesheets/hyrax/_file-listing.scss#L100-L104

@adamjarling adamjarling self-assigned this Nov 1, 2018
@adamjarling adamjarling changed the title Remove buttons for collection participants are inconsistent Admin Set and Collection participants tab layouts are inconsistent Nov 1, 2018
@adamjarling
Copy link
Member

@cjcolvar I'm updating the scope of this ticket a bit to address what I think is the underlying issue. In the collection extensions sprint, we re-factored the Participants tab layout for a Collection, but these didn't carry through to the Admin Set Participants tab view. Seems that they should probably be using the same view partial since so much of the markup is the same, but will save that for another time. Updating the layout, should fix the button issue, and more.

admin-set-participants-tab

collections-participants-tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants