Make Admin Set Participants tab layout match Collections Sharing tab … #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 6, 2018
| @@ -97,8 +97,7 @@ h4 .small { | |||
| text-decoration: none; | |||
| } | |||
|
|
|||
| input.batch_document_selector, | |||
| input.disabled { | |||
| input.batch_document_selector { | |||
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
Selector batch_document_selector should be written in lowercase with hyphens
There was a problem hiding this comment.
This was a previously defined CSS class, didn't add it.
|
@adamjarling @no-reply Should this be put in the 3.x milestone? |
|
@cjcolvar Not really sure. It doesn't change the way Admin Set participants page actions are being handled, but it does adjust the UI. |
adamjarling
force-pushed
the
3365-collections-participants-remove-button-sizing-inconsistency
branch
from
6e2adcb
to
69d7e0d
Compare
…layout. Also update the add users and add group forms to use Bootstrap inline-forms with cleaner markup
adamjarling
force-pushed
the
3365-collections-participants-remove-button-sizing-inconsistency
branch
from
69d7e0d
to
132061c
Compare
no-reply
approved these changes
Nov 12, 2018
no-reply
deleted the
3365-collections-participants-remove-button-sizing-inconsistency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…layout. Also update the add users and add group forms to use Bootstrap inline-forms with cleaner markup
Fixes #3365
Cleans up the UI / layout of Admin Set Participants tab view, to match Collections Sharing tab view. Also cleans up the Bootstrap
form-inlinemarkup to better follow Bootstrap convention.After
Before
@samvera/hyrax-code-reviewers