Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VisibilityCopyJob to receive either an ActiveFedora object or a Valkyrie resource #4198

Closed
randalldfloyd opened this issue Jan 22, 2020 · 2 comments
Labels

Comments

@randalldfloyd
Copy link
Contributor

Descriptive summary

Convert VisibilityCopyJob to allow it to receive either an ActiveFedora based object or a Valkyrie::Resource equivalent object.

Rationale

Allow jobs to execute correctly with existing AF implementation or the Wings Valkyrie implementation.

Expected behavior

VisibilityCopyJob receives a Valkyrie::Resource and performs the action.

Actual behavior

VisibilityCopyJob raises an exception when passed a Valkyrie::Resource.

Approach for Conversion

See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource

Related work

These have all be modified to support AF object or Valkyrie resource using the [established pattern]((https://docs.google.com/document/d/1f9yDjtkXapFf1DYLyPhprnB4CPGaZw9p_k8T_tcor-U/edit#heading=h.qt9rxydfd727).

@bkeese
Copy link
Contributor

bkeese commented Jan 23, 2020

This one has already been valkyrized, as of this commit:
1367040#diff-ebb7ea117a9e3897947709cd755ab906

@randalldfloyd
Copy link
Contributor Author

@bkeese Thanks for running that one down. I'll close this with the added comment for future inspection: the reason this one works is because the downstream propagator (Hyrax::VisibilityPropagator) was refactored to allow a Valkyrie resource. That's not totally apparent at a glance for this job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants