You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bkeese Thanks for running that one down. I'll close this with the added comment for future inspection: the reason this one works is because the downstream propagator (Hyrax::VisibilityPropagator) was refactored to allow a Valkyrie resource. That's not totally apparent at a glance for this job.
Descriptive summary
Convert VisibilityCopyJob to allow it to receive either an ActiveFedora based object or a Valkyrie::Resource equivalent object.
Rationale
Allow jobs to execute correctly with existing AF implementation or the Wings Valkyrie implementation.
Expected behavior
VisibilityCopyJob receives a Valkyrie::Resource and performs the action.
Actual behavior
VisibilityCopyJob raises an exception when passed a Valkyrie::Resource.
Approach for Conversion
See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource
Related work
These have all be modified to support AF object or Valkyrie resource using the [established pattern]((https://docs.google.com/document/d/1f9yDjtkXapFf1DYLyPhprnB4CPGaZw9p_k8T_tcor-U/edit#heading=h.qt9rxydfd727).
The text was updated successfully, but these errors were encountered: