Allow RevokeEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work

[elrayle]

Descriptive summary

Convert RevokeEditToMembersJob to allow it to receive either an ActiveFedora based FileSet or a Valkyrie::Resource equivalent Work.

Rationale

Allow jobs to execute correctly with existing AF implementation or the wings Valkyrie implementation.

Expected behavior

RevokeEditToMembersJob receives a Valkyrie::Resource and performs RevokeEditJob for each member FileSet.

To get the list of FileSet ids from a work resource, use...

file_set_ids = Hyrax.query_service.custom_queries.find_child_fileset_ids(resource: work_resource)

Coordinate with Issue #4106 to pass use_valkyrie: true when a Valkyrie::Resource was received and false if not.

Actual behavior

RevokeEditToMembersJob raises an exception (perhaps: NoMethodFound for #search_with_conditions) when passed a Valkyrie::Resource.

Approach for Conversion

See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource

Steps to reproduce the behavior

1. Need to add tests that validate that the same tests pass whether a Valkyrie::Resource or an AF object is passed.

See example of processing both objects in... file_set_actor_spec.rb

For testing this job, you can use something like...

RSpec.describe RevokeEditToMembersJob do
  [true, false].each do |test_valkyrie|
    context "when test_valkyrie is #{test_valkyrie}" do
      let(:af_work) { create(:work) }
      let(:valk_file_set) { af_work.valkyrie_resource }
      let(:work) { test_valkyrie ? valk_file_set : af_work }

Related work

• Issue Process GrantEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter #4104 Process GrantEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter
• Issue Process GrantReadJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter #4105 Process GrantReadJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter
• Issue Process RevokeEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter #4106 Process RevokeEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter
• Issue Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4101 Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work
• Issue Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4102 Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work
• Issue Allow CharacterizeJob to receive either an AF object or a Valkyrie resource as the FileSet #4100 Allow CharacterizeJob to receive either an AF object or a Valkyrie resource as the FileSet
• Issue Add GlobalID::Identification for resources passed to jobs #4099 Add GlobalID::Identification for resources passed to jobs

[elrayle]

Fixed by PR #4123