Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure spec/controllers/hyrax/single_use_links_controller_spec.rb passes on .koppie #6195

Closed
no-reply opened this issue Aug 24, 2023 · 3 comments

Comments

@no-reply
Copy link
Contributor

spec/controllers/hyrax/single_use_links_controller_spec.rb is failing on koppie builds. there may be a number of reasons for this:

  1. the test setup uses ActiveFedora, and should be refactored to use Valkyrie;
  2. the tests themselves test behavior that only applies to ActiveFedora, and should be turned off by adding the :active_fedora rspec metadata;
  3. the unit under test depends on ActiveFedora and needs to be rewritten to use Valkyrie throughout;
  4. some combination of the above.

docker-compose -f docker-compose-koppie.yml build
docker-compose -f docker-compose-koppie.yml up
docker-compose -f docker-compose-koppie.yml exec -w /app/samvera/hyrax-engine app sh -c "bundle exec rspec spec/controllers/hyrax/single_use_links_controller_spec.rb"
@hackartisan
Copy link
Contributor

Given that we have #6204, probably option 3 is at play here.

@lsitu
Copy link
Contributor

lsitu commented Aug 30, 2023

I tested with docker-compose -f docker-compose-koppie.yml exec -w /app/samvera/hyrax-engine app sh -c "bundle exec rspec spec/controllers/hyrax/single_use_links_controller_spec.rb" several times on the latest main branch and it all passed. It looks like the issue is gone and we can close it.

@no-reply
Copy link
Contributor Author

i also see this issue fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants