Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a single use link generates argument error in valkyrie #6204

Closed
rjkati opened this issue Aug 24, 2023 · 2 comments · Fixed by #6226
Closed

Using a single use link generates argument error in valkyrie #6204

rjkati opened this issue Aug 24, 2023 · 2 comments · Fixed by #6226
Assignees
@tpendragon
Labels
valkyrization

Comments

@rjkati
Copy link

rjkati commented Aug 24, 2023

Descriptive summary

When I attempt to use a single use link to a fileset, I get an ArgumentError in Hyrax::SingleUseLinksViewerController#download page instead of the file.

This works as expected on dev.nurax, but not pg.nurax

Steps to reproduce the behavior in User Interface (UI)

  1. Deposit a work with institution, embargoed or private visibility.
  2. On the work show page for the work which you deposited in step 1, scroll down to the Items section and click on the file name
  3. Click the Create Single-Use Link button
  4. Click Copy under the Single-Use Links header
  5. Go to a different browser and paste the single use link
  6. Observe error message

Actual behavior (include screenshots if available)

Using a single-use link generates an error

single-use_link_error

Acceptance Criteria/Expected Behavior

Using a single-use link should download the file associated with the link.
@tpendragon
Copy link
Contributor

The related test might be reflected in #6195

@hackartisan hackartisan mentioned this issue Aug 25, 2023
Closed
@tpendragon tpendragon self-assigned this Aug 25, 2023
tpendragon added a commit that referenced this issue Aug 25, 2023
@tpendragon
Fix single use links for Valkyrie.
8768152 
Closes #6204

This also adds a shortcut to allow creating a work that has a file,
including a FileSet, FileMetadata, and File Identifier. I'm not sure
it's the best, but it works really well for this test!
@tpendragon tpendragon mentioned this issue Aug 25, 2023
Merged
no-reply pushed a commit that referenced this issue Aug 28, 2023
@tpendragon
Fix single use links for Valkyrie.
f74bd3c 
Closes #6204

This also adds a shortcut to allow creating a work that has a file,
including a FileSet, FileMetadata, and File Identifier. I'm not sure
it's the best, but it works really well for this test!
@rjkati
Copy link
Author

rjkati commented Aug 31, 2023

I can now generate a single use link to a file and successfully download the file associated with that link on pg.nurax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpendragon tpendragon

Labels
valkyrization
Projects
Hyrax-Valkyrization
Status: DONE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix single use links for Valkyrie. samvera/hyrax
2 participants
@tpendragon @rjkati