Move license attribute row from _metadata partial to _attribute_rows …

[adamjarling]

…partial

Fixes #394

This PR attempts to fix "Move rights rows from _metadata to _attribute_rows", but see issue #394 for needed clarification of what's the acceptance criteria for this issue. It's not clear to me.

@samvera/hyrax-code-reviewers

[cjcolvar]

We actually made this same change in our hyrax app so I think this is a good change.

[no-reply]

I'd like to get this in in the near future, but I have a concern:

Many apps override _attribute_rows, but not _metadata, which means this change will remove license from their runtime copies of _metadata, but not add it to _attribute_rows.

I'd like to hold this for the time being. I've put it on the agenda for Samvera Tech next week.

[RudyOnRails]

Looks like this agenda item got lost in the setup of the next week's agenda: https://wiki.duraspace.org/display/samvera/Copy+of+Samvera+Tech+Call+2018-07-25

I have added it to the new agenda for next week..

[no-reply]

There is consensus on Samvera Tech is that this would constitute a breaking change and require bumping the version to 3.0.

Since it's a small change, I'm inclined to hold it until we have other API changes in the pipeline.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[no-reply]

Considering this along with #3121 as motivating 3.0.0 soon.

Requesting feedback, especially from @vantuyls @samvera/hyrax-code-reviewers @samvera/hyrax-repo-managers

[adamjarling]

@no-reply What do you suggest for this? Ok to merge now?

[no-reply]

Yay!

I started a draft release for v3.0.0-beta1 at https://github.com/samvera/hyrax/releases/tag/untagged-2151e64eb6ad0bfb86e9