Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor the layout (and buttons, original motivation) for the work show page #3374

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

adamjarling
Copy link
Member

@adamjarling adamjarling commented Nov 5, 2018

Fixes #3364

See #3364 for more details, but essentially this PR updates the layout of a Work Show page.

Before

generic-work-show-page-before

After

generic-work-show-page-idea-v2

@samvera/hyrax-code-reviewers

@adamjarling adamjarling self-assigned this Nov 5, 2018
@adamjarling adamjarling force-pushed the 3364-work-show-page-layout-refactor branch from 714925f to 613c4bc Compare November 5, 2018 16:53
@no-reply
Copy link
Contributor

no-reply commented Nov 5, 2018

How badly do you think this orphans content if existing adopters have copied any of these views in wholesale? It looks like it might not be too bad at a glance(?).

I'm trying to gauge whether we should roll this into a 2.5.0 (this rearrangement seems like more than a bugfix), or hold for merge along with the existing 3.0.0 items later this week.

@chrisdaaz
Copy link

i recommend rolling out adam's UI enhancements along with 3.0.0

@adamjarling
Copy link
Member Author

@no-reply Hmm, I think it depends on how much each customization has strayed from the original view. There are some changes that could break a custom layout, but I don't think it'd be that hard to fix? It's hard to say in general.

I'm working on the Collections View page at the moment (on request from @julesies in the Repo managers Slack channel), and that will follow the same patterns as this page.

So if someone has customized their Hyrax views, this change is starting to consolidate styles, layouts and hopefully will eventually help making customizing easier.

@no-reply no-reply added this to the 3.x series milestone Nov 5, 2018
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@no-reply no-reply merged commit 2cf4ab2 into master Nov 12, 2018
@no-reply no-reply deleted the 3364-work-show-page-layout-refactor branch November 12, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants