Use Hydra.config.user_key_field to determine User#user_key
#3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
previously approved these changes
Jan 25, 2019
`#user_key` was previously out-of-sync with `.find_by_user_key`. The latter used application level configuration, while the former was hard coded to `Devise.authentication_keys.first` implementation via `Blacklight::AccessControls::User`. Here they are realigned, and derived from the `Hydra`-level configuration. Adds a method `User.user_key_field` to encapsulate the key field data, and uses it throughout the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#user_keywas previously out-of-sync with.find_by_user_key. The latter usedapplication level configuration, while the former was hard coded to
Devise.authentication_keys.firstimplementation viaBlacklight::AccessControls::User. Here they are realigned, and derived from theHydra-level configuration.Adds a method
User.user_key_fieldto encapsulate the key field data, and uses it throughout the class.@samvera/hyrax-code-reviewers