Use [* TO *] to work with old and new versions of AF and Solr #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Mar 4, 2019
Closed
|
Will this require action for existing installations? |
|
No, it shouldn't. Only new apps generated with AF 12.1.0 will get the new default schemas and this code change allows them to work with the new schema. Older apps will still have the older default schema which will still work with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveFedora 12.1.0 brings a new solr schema which switches from the deprecated solr.TrieDateField (to be removed in solr 8) to solr.DatePointField. While the TrieDateField allowed queries like
date_dtsi:*, DatePointField only allows single value and range queries so this example query needs to change todate_dtsi:[* TO *]. Luckily the latter also works in TrieDateField. This PR updates both the embargo and lease search builders to use the[* TO *]query to work with both types of solr fields.This fixes the tests that were blocking #3541
@samvera/hyrax-code-reviewers