Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when tabbing in relationship tab, allow user to reach "Add" buttons. #3709

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Mar 22, 2019

Fixes #3453

When adding/editing a work and user goes to the relationship tab, the user will be able to tab to the "Add" buttons on the page.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • From the dashboard, add 2 new works, and a collection
  • After the works are added, edit one of the new works.
  • Navigate to the relationship tab, you should see two Add buttons.
  • You should be able to tab to each of the "Add" buttons.

@samvera/hyrax-code-reviewers

@blancoj blancoj changed the title when tabing in relationship tab, allow user to reach "Add" button. [WIP] when tabbing in relationship tab, allow user to reach "Add" button. Mar 22, 2019
@blancoj blancoj changed the title [WIP] when tabbing in relationship tab, allow user to reach "Add" button. when tabbing in relationship tab, allow user to reach "Add" buttons. Mar 22, 2019
dlpierce
dlpierce previously approved these changes Apr 16, 2019
@cjcolvar
Copy link
Member

@blancoj Do you mind rebasing this PR on the latest in master? I think this will resolve the circleci failures.

@dlpierce dlpierce merged commit 2354989 into master Apr 24, 2019
@dlpierce dlpierce deleted the issue-3453 branch April 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard user can't add works to collections or add child works
4 participants