Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when downloading from Box, use label for filename #3718

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Mar 26, 2019

Fixes #1684

Presently when downloading from Box, the file(s) downloaded take(s) on the name "download". By setting the filename to the label in file_set, this is remedied.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • When testing this on local, you will have to create an app for box. From this page https://developer.box.com/docs/authenticate-with-developer-token go to the link to "developer console" . There, create an app and in the config section for your new app, you will be able to get the client_id and client_secrete which you will have to update .internal_test_app/config/browse_everything_providers.yml with.

Screen Shot 2019-03-26 at 3 51 00 PM

  • Either create a new work or Edit an existing work.
  • Select the "Files" tab
  • Select the button "Add cloud files..."
  • Select a few files from Box
  • Save the work.
  • Go the the work page and try to download the files you just uploaded from Box.
  • The files you downloaded should have the appropriate filename

@samvera/hyrax-code-reviewers

Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Box works for me. 👍

@no-reply no-reply merged commit f5c25cf into master Apr 18, 2019
@no-reply no-reply deleted the issue-1684 branch April 18, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloads of files uploaded via browse-everything (Box) have no file extension
3 participants