Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

center headings in work listed in dashboard. #3759

Merged
1 commit merged into from
Apr 26, 2019
Merged

center headings in work listed in dashboard. #3759

1 commit merged into from
Apr 26, 2019

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Apr 25, 2019

Fixes #3721

This PR address the headers and values listed on the dashboard for works. Many values were not centered.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Go to dashboard/my/works page
  • Verify that the headers of the table and values are centered, with the exception of the 1st 2 columns
  • Got to dashboard/works page
  • Verify that the headers of the table and values are centered, with the exception of the 1st 2 columns

@samvera/hyrax-code-reviewers

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blancoj the change looks fine, but the tests have failed with

1) Sending an email via the contact form sends mail
     Failure/Error: <%= render_thumbnail_tag(recent_document, {width: 90}, {suppress_link: true}) + recent_document.to_s %>

I can't see how that would be related, but it needs to pass before we can merge.

I'll try a re-run of circleci in case that fixes it.

@ghost ghost merged commit 9db6ee5 into master Apr 26, 2019
@ghost ghost deleted the issue-3721 branch April 26, 2019 16:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

my/works: align title and symols
2 participants