fix current logic error in displaying/hiding feature/unfeature buttons

[yf508]

Fixes #3169

The current implementation of showing/hiding feature/unfeature buttons seems to be incorrect.

e.g. for feature button:

<%= link_to "Feature", hyrax.featured_work_path(presenter, format: :json),
data: { behavior: 'feature' },
class: presenter.display_unfeature_link? ? 'btn btn-default collapse' : 'btn btn-default' %>

It says, "if display_unfeature_link returns true, then hide feature button, OTHERWISE, show feature button". While display_unfeature_link returns false, it doesn't necessarily mean feature button needs to be shown. For example, when 5 works have been featured already, both feature/unfeature buttons should be hidden for new objects. Therefore, to make it simple and working:

<%= link_to t('.feature'), hyrax.featured_work_path(presenter, format: :json),
data: { behavior: 'feature' },
class: presenter.display_feature_link? ? 'btn btn-default' : 'btn btn-default collapse' %>

@samvera/hyrax-code-reviewers

[no-reply]

This looks good to me.

Added a Check CLA label.

[cjcolvar]

@yf508 Thanks for the pull request! In order for us to merge this code, we'll need to have signed Contributor License Agreements on file for you as an individual and your employer. (If you work for University of York then it looks like we already have the cCLA.) You can read more about the Samvera community's CLA processes here:
https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership

[cjcolvar]

Requires iCLA before merging.

[yf508]

I have sent the iCLA via email.

[cjcolvar]

👍 Looks like it has been received. Thanks!

[cjcolvar]

👍