[wings] Remove convert_class_name_to_valkyrie_resource_class
#3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
previously approved these changes
Aug 29, 2019
|
👍 |
VivianChu
force-pushed
the
remove-resolver
branch
from
04cff6a
to
f766280
Compare
|
@elrayle @VivianChu if you both approve of this PR, could one of you get in an approval? |
VivianChu
previously approved these changes
Sep 4, 2019
VivianChu
force-pushed
the
remove-resolver
branch
from
f766280
to
1567c1e
Compare
This was an early addition to Wings, and predates much of the query work. at this point, objects round trip just fine without the special class casting handling. For certain adapters (e.g. the memory adapter) the call to `internal_resource` results in a `NoMethodError` on `Object`, so this seems like a good time to remove the superflouous code.
no-reply
force-pushed
the
remove-resolver
branch
from
1567c1e
to
bda7ed0
Compare
|
rebased once again. |
VivianChu
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an early addition to Wings, and predates much of the query work. at
this point, objects round trip just fine without the special class casting
handling. For certain adapters (e.g. the memory adapter) the call to
internal_resourceresults in aNoMethodErroronObject, so this seems likea good time to remove the superfluous code.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers