Replace calls to ActiveFedora::Base.search_by_id #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsitu
changed the title
no-reply
reviewed
Sep 4, 2019
lsitu
force-pushed
the
active_fedora_search_by_id
branch
from
27f082f
to
d12f3fa
Compare
no-reply
suggested changes
Sep 10, 2019
app/models/hyrax/base.rb
Outdated
| @@ -0,0 +1,11 @@ | |||
| module Hyrax | |||
| class Base | |||
There was a problem hiding this comment.
does it make sense for this to live in a Base class? What about pushing this into a search service?
I think it would be worth looking about in services/hyrax to see if there's already a natural home for this functionality.
There was a problem hiding this comment.
Alternatively, both existing calls seem like they're weird optimizations, designed to avoid loading data from fedora. I wonder if we couldn't refactor them away?
There was a problem hiding this comment.
@no-reply I've moved it to Hyrax::SolrService class since the behavior of the method is related to SOLR search. And yes, it seems like something that we could refactor at some point later.
lsitu
force-pushed
the
active_fedora_search_by_id
branch
4 times, most recently
from
6fabf64
to
78c858e
Compare
Hyrax::Base.search_by_id.
Hyrax::ObjectNotFoundError.
lsitu
force-pushed
the
active_fedora_search_by_id
branch
from
78c858e
to
ec5cf2e
Compare
no-reply
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3822
Replace calls to ActiveFedora::Base.search_by_id with Hyrax::Base.search_by_id.
@samvera/hyrax-code-reviewers