[wings] Round trip registered valkyrie native classes #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
native-models-2
branch
from
8fd49b2
to
67fb9bd
Compare
no-reply
force-pushed
the
native-models-2
branch
2 times, most recently
from
ac966b8
to
1478d9c
Compare
no-reply
commented
Sep 18, 2019
| # | ||
| # # `Wings` will cast the `BookResource` to a `Book` to persist via `ActiveFedora` | ||
| # resource = BookResource.new(author: 'Tove Jansson', title: 'Comet in Moominland') | ||
| # adapter = Wings::Valkyrie::MetadataAdapter.new |
There was a problem hiding this comment.
i chose to use Wings::Valkyrie::MetadataAdapter.new here to show this working explicitly with the wings adapter. i guess we could change either this or the Hyrax.persister on L25, but honestly I'm not thinking it matters. It might be good to show the ways of selecting persisters, and just get better inline documentation for Hyrax.persister in at the Hyrax level.
elrayle
previously approved these changes
Sep 18, 2019
| end | ||
| end | ||
|
|
||
| after do | ||
| Object.send(:remove_const, :Book) | ||
| Object.send(:remove_const, :Image) | ||
| Hyrax::Test.send(:remove_const, :QueryService) |
There was a problem hiding this comment.
I like this! Makes for easier removal of constants defined in tests.
There was a problem hiding this comment.
yeah, we should probably start using Hyrax::Test everywhere test constants are needed
Users will want to define their models with native Valkyrie. This supports a transition by allowing them to define Valkyrie analogues for their existing ActiveFedora models.
|
👍 |
no-reply
force-pushed
the
native-models-2
branch
from
1478d9c
to
76c704b
Compare
elrayle
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3671; supersedes #3937
Users will want to define their models with native Valkyrie. This supports a transition by allowing them to define Valkyrie analogues for their existing ActiveFedora models.
New Valkyrie models need to be registered with
Wingsto cast to the correct ActiveFedora models within Wings. Wings continues to return meta-programmed model objects, but these now subclass the user's native Valkyrie models.Changes proposed in this pull request:
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers