Rename Hyrax.collection.browse_view to edit_view & update value
#4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This view is more properly called the 'Edit View' and that should be reflected in the breadcrumbs. The i18n key was previously also `browse_view` and changing it to `edit_view` helps ensure translations get updated. Fixes #2164.
no-reply
force-pushed
the
hyrax-collection-edit-view-key
branch
from
4b42e1e
to
493967a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This view is more properly called the 'Edit View' and that should be reflected
in the breadcrumbs. The i18n key was previously also
browse_viewand changingit to
edit_viewhelps ensure translations get updated.Fixes #2164.
Changes proposed in this pull request:
i18nkey for the collection edit view toedit_viewGuidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers