-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert file ids in resource fileset to pcdm files in AF fileset #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
wings/af_converter_files
branch
from
September 30, 2019 13:25
8d2b086
to
a2c72c6
Compare
elrayle
added a commit
that referenced
this pull request
Sep 30, 2019
Allows CharacterizeJob to receive a Valkyrie::Resource and immediately convert it to an AF object. This allows callers of this job to be fully valkyrized. PR #4055 Convert file ids in resource fileset to pcdm files in AF fileset Make CharacterizationJob able to process a Valkyrie::Resource. This supports full valkyrization of new service Hyrax::Files::IngestFileService (replacing FileActor #ingest_file method).
elrayle
added a commit
that referenced
this pull request
Sep 30, 2019
Allows CharacterizeJob to receive a Valkyrie::Resource and immediately convert it to an AF object. This allows callers of this job to be fully valkyrized. PR #4055 Convert file ids in resource fileset to pcdm files in AF fileset Make CharacterizationJob able to process a Valkyrie::Resource. This supports full valkyrization of new service Hyrax::Files::IngestFileService (replacing FileActor #ingest_file method).
elrayle
force-pushed
the
wings/af_converter_files
branch
2 times, most recently
from
October 14, 2019 20:38
4459c18
to
b4c514e
Compare
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
elrayle
force-pushed
the
wings/af_converter_files
branch
3 times, most recently
from
January 22, 2020 22:42
dba5dc2
to
e9d650b
Compare
Co-authored-by: cjcolvar <cjcolvard@indiana.edu>
Tests: * PASS versioning: false * PASS versioning: true and first file * FAIL versioning: true and second file (test marked pending)
elrayle
force-pushed
the
wings/af_converter_files
branch
from
January 22, 2020 23:11
e9d650b
to
a1b46b7
Compare
elrayle
changed the title
[WIP] Convert file ids in resource fileset to pcdm files in AF fileset
Convert file ids in resource fileset to pcdm files in AF fileset
Jan 23, 2020
Solution: Instead of...
We switched to using...
|
jeremyf
approved these changes
Jan 23, 2020
fixes #4060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
convert_files
to the process that converts a resource to af objectRelated to Issue #4060 Wings: Round trip conversion of files does not maintain file relationships
Description of Issue with this PR
When round tripping from AF to Valk to AF, the existing file is assigned a new ID while being set on the FileSet
Behaviors
The described behaviors assume the same starting
fileset1
object created in Issue #3406rt_fileset
is the round trip fileset from the conversion fromfileset1
to a valkyrieresource
and back to an ActiveFedora based fileset.Expected behavior
Actual behavior using this PR's
ActiveFedoraConverter #convert_file
methodNOTE: The original_file's ID and URI show the file in the same fileset, but it has a different unique identifier extension for the file.
To Reproduce
Trace of significant method calls causing the IDs to be different
In Wings::ActiveFedoraConverter #convert_files call #convert_file with line...
calls ActiverFedora::Attributes #[]= with line...
calls ActiveFedora::Associations::DirectlyContainsOneAssociation #replace with line...
calls ActiveFedora::Associations::DirectlyContainsOneAssociation #add_to_container with line...
calls ActiveFedora::Associations::DirectlyContainsAssociation #initialize_attributes with line...
which mints the new id for the existing PCDM File