Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wings] Implement #name for classes generated by OrmConverter #4059

Merged
merged 1 commit into from
Oct 3, 2019
Merged

[wings] Implement #name for classes generated by OrmConverter #4059

merged 1 commit into from
Oct 3, 2019

Conversation

no-reply
Copy link
Contributor

@no-reply no-reply commented Oct 1, 2019

Allows Wings generated classes to have a .name for #inspect and error reporting cases.

@samvera/hyrax-code-reviewers

@no-reply no-reply added the wings label Oct 1, 2019
hweng
hweng approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@hweng hweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@no-reply no-reply merged commit a6de854 into master Oct 3, 2019
@no-reply no-reply deleted the name branch October 8, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hweng hweng hweng approved these changes

Assignees
No one assigned
Labels
wings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no-reply @hweng