Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Valkyrie native Collections as PcdmCollection #4076

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Implement Valkyrie native Collections as PcdmCollection #4076

merged 4 commits into from
Oct 17, 2019

Commits on Oct 15, 2019

  1. Implement Valkyrie native Collections as PcdmCollection 

    Add a PCDM style collection in native Valkyrie, with support for
membership. Extract Work membership tests into shared examples for use across
PCDM/Works models.

We name the Collection model `Hyrax::PcdmCollection` to avoid application layer
collisions with `::Collection` when referring to it from a Hyrax module. That
is: we don't want to introduce a `Hyrax::Collection` without warning adopters.
    Tom Johnson committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    c08be1e View commit details
    Browse the repository at this point in the history

  2. Move Hyrax::Schema and valkyrie metadata specifications into lib 

    `Schema` is a base level dependency for much of Hyrax post-Valkyrie, so putting
it in `lib` seems to make sense. This makes it easy to require independently
when it needs to be used in, e.g. `Wings`.
    Tom Johnson committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    20a1cb3 View commit details
    Browse the repository at this point in the history

  3. Add collection_type_gid to Valkyrie native collection 

    Collections in Hyrax need a collection type. We link them to a `GlobalID` for a
`CollectionType` using `#collection_type_gid`. This closely mirrors the old
`Hyrax::CollectionBehavior` approach.
    Tom Johnson committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    adf777e View commit details
    Browse the repository at this point in the history

  4. [wings] Enable Collection round-tripping with Wings 

    Setup a mapping between `Hyrax::PcdmCollection` and `::Collection` for use in
Wings adapters.

Introduce a `:hyrax_collection` factory with some basic membership accessors.
    Tom Johnson committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    b2d1d24 View commit details
    Browse the repository at this point in the history