Use the Hyrax::TimeService for events
#4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Hyrax::Event` usually wants to be created "now". For Hyrax, "now" generally means `Hyrax::TimeService.time_in_utc`. We switch to using this method, and add a utility method for this. The method is convenient for users, and extracts behavior from `EventJob` where it's not as visibile to users who might be trying to understand how to use the Event.
jcoyne
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyrax::Eventusually wants to be created "now". For Hyrax, "now" generallymeans
Hyrax::TimeService.time_in_utc.We switch to using this method, and add a utility method for this. The method is
convenient for users, and extracts behavior from
EventJobwhere it's not asvisible to users who might be trying to understand how to use the Event.
@samvera/hyrax-code-reviewers