Use uploaded_file for new versions #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
uploaded-versions
branch
from
61d74c7
to
eadea7d
Compare
ghost
changed the title
no-reply
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with file version where the jobs are being run on a different server to the web application - a common scenario in production.
New file versions are uploaded to the system temp (normally /tmp) and so cannot be found on the jobs server.
I have fixed this in the
FileSetsControllerby creating aHyrax::UploadedFilefor the new version. This is in line with behaviour for uploading files during work create and update, and ensures that the file is written to the hyrax uploads directory, which will have been shared across servers.@samvera/hyrax-code-reviewers