Decode filenames for fileset label #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
decode-filenames
branch
from
259faea
to
35d52b4
Compare
ghost
changed the title
no-reply
approved these changes
Dec 26, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where non-ascii characters in filenames were being encoded when creating the file_set label in the
Hyrax::FileSetActor. Changing the code to useAddressable::URI.unencodeinstead ofAddressable::URI.parsefixes this issue.I have added a test with Japanese characters.
Before:
After:
I am unsure if there is any downside to no longer using parse.
nb. the one failed test on
ruby2-4-7is a bit of a headscratcher.