Remove collection size feature #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
previously approved these changes
Jan 23, 2020
jeremyf
reviewed
Jan 23, 2020
mjgiarlo
force-pushed
the
nuke_collection_file_size
branch
from
567cf77
to
c57f998
Compare
While looking into #4100, we noticed that `CharacterizeJob` not only saves a file set's `original_file`, but also reindexes the file set, *and* reindexes every collection to which the file set's work belongs. It appears that this feature was added way back in the Sufia days in order to support the use case of displaying on the collection show page the total size of all files uploaded to a collection's works. Why is this problematic? At large scale, this means touching a potentially huge portion of the repository—iterating over all files in all works in a collection—in order to display an arguably useful string to a subset of repository users who care about such information. Doing this in `CharacterizeJob` introduces significant potential delay in the ingest pipeline, increasing how long it takes for a deposit to finish and render in the Hyrax UI (e.g., by delaying the creation of derivatives). We propose removing this feature for now and encourage folks who need this feature to contribute it back with a better-performing, more streamlined design.
mjgiarlo
force-pushed
the
nuke_collection_file_size
branch
from
c57f998
to
84b4016
Compare
|
💯 to this! thanks. i do think it would be nice to make the public methods emit deprecation warnings and return hard-coded & compatible null-ish values |
no-reply
force-pushed
the
nuke_collection_file_size
branch
from
db58889
to
2b2b9c5
Compare
mjgiarlo
commented
Jan 24, 2020
mjgiarlo
force-pushed
the
nuke_collection_file_size
branch
from
2b2b9c5
to
623292f
Compare
jeremyf
approved these changes
Jan 24, 2020
|
I know this is already merged, but I just want to add my kudos to @mjgiarlo (and any others working on this PR). Always happy to see performance enhancements. |
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #4100, we noticed that
CharacterizeJobnot only saves a file set'soriginal_file, but also reindexes the file set, and reindexes every collection to which the file set's work belongs. It appears that this feature was added way back in the Sufia days in order to support the use case of displaying on the collection show page the total size of all files uploaded to a collection's works.Why is this problematic?
At large scale, this means touching a potentially huge portion of the repository—iterating over all files in all works in a collection—in order to display an arguably useful string to a subset of repository users who care about such information. Doing this in
CharacterizeJobintroduces significant potential delay in the ingest pipeline, increasing how long it takes for a deposit to finish and render in the Hyrax UI (e.g., by delaying the creation of derivatives).We propose removing this feature for now and encourage folks who need this feature to contribute it back with a better-performing, more streamlined design.