Use a Hyrax configuration option to set the system virus scanner #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used `Hyrax.primary_work_type` to set the system wide virus scanner. There appears to be no reason for this to be configurable on a per-work basis; we always use the "primary work type" (i.e. whichever one happens to be first in the registered work types list!) to choose the virus scanner. Using a system-wide configuration is much more clear. The default for this configuration is to fall back on the `primary_work_type`'s configured scanner.
no-reply
force-pushed
the
config-virus-scanner
branch
from
a14c299
to
645fa92
Compare
jcoyne
approved these changes
Jan 24, 2020
mjgiarlo
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
Hyrax.primary_work_typeto set the system wide virusscanner. There appears to be no reason for this to be configurable on a
per-work basis; we always use the "primary work type" (i.e. whichever one
happens to be first in the registered work types list!) to choose the virus
scanner.
Using a system-wide configuration is much more clear. The default for this
configuration is to fall back on the
primary_work_type's configured scanner.@samvera/hyrax-code-reviewers