Removes configurability for resource indexer in solr indexing adapter

[straleyb]

Fixes #issuenumber ; refs #issuenumber

This PR pushes up some changes that had been discussed at Solar Vortex. There is not much of a reason to have a configurable indexer for the Indexing adapters. This is for the fact that indexing adapters will be the piece that is created and registered. So if someone wishes to use a new resource indexer in a specific adapter, they would either swap it or register a new indexer.

There are no tests that tested the configurability of the adapter as it was a way to create an ambiguous enough interface for testing purposes.

@samvera/hyrax-code-reviewers

[straleyb]

Side question here. This test doesn't utilize these two lines. Was the goal of this to get it to use the persister to call save instead of call save on the adapter?

hyrax/spec/valkyrie/indexing/solr/indexing_adapter_spec.rb

Lines 7 to 8 in d646a36

	let(:persister) { Wings::Valkyrie::Persister.new(adapter: metadata_adapter) }
	let(:metadata_adapter) { Wings::Valkyrie::MetadataAdapter.new }

[no-reply]

Side question here. This test doesn't utilize these two lines. Was the goal of this to get it to use the persister to call save instead of call save on the adapter?

hyrax/spec/valkyrie/indexing/solr/indexing_adapter_spec.rb

Lines 7 to 8 in d646a36

	let(:persister) { Wings::Valkyrie::Persister.new(adapter: metadata_adapter) }
	let(:metadata_adapter) { Wings::Valkyrie::MetadataAdapter.new }

looks like cruft to me. introduced here: 57450b5#diff-25d623799bda9453d7d1af9e8047932f

[straleyb]

Not sure why ruby 2.5.5 failed and 2.4.7 is hanging. Ill keep an eye on this for any updates, but I think it should be good to go now.

[straleyb]

@no-reply Should I run the tests again for the failed 2.5.5? The failures look unrelated.

[no-reply]

oops, just caught that this reader was left in place

[straleyb]

@no-reply Got this back up to speed.

[straleyb]

@no-reply I updated it to use that method to return the indexer. Definitely more hyrax-y and doesn't keep an unnecessary instance variable around. Good call on this one.