Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 2 6 remove collection size feature hyrax 4207 #4237

Merged

Commits on Jan 30, 2020

  1. Remove collection size feature

    While looking into #4100, we noticed that `CharacterizeJob` not only saves a file set's `original_file`, but also reindexes the file set, *and* reindexes every collection to which the file set's work belongs. It appears that this feature was added way back in the Sufia days in order to support the use case of displaying on the collection show page the total size of all files uploaded to a collection's works.
    
    Why is this problematic?
    
    At large scale, this means touching a potentially huge portion of the repository—iterating over all files in all works in a collection—in order to display an arguably useful string to a subset of repository users who care about such information. Doing this in `CharacterizeJob` introduces significant potential delay in the ingest pipeline, increasing how long it takes for a deposit to finish and render in the Hyrax UI (e.g., by delaying the creation of derivatives).
    
    We propose removing this feature for now and encourage folks who need this feature to contribute it back with a better-performing, more streamlined design.
    mjgiarlo authored and fritzfreiheit committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    de53860 View commit details
    Browse the repository at this point in the history
  2. Deprecate public methods for removed collection size feature

    Tom Johnson authored and fritzfreiheit committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    e192222 View commit details
    Browse the repository at this point in the history