Removing reference to Valkyrie on 2.x branch #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change came as part of some PRs/merging that happened upstream. As a result, it broke the build.
This is a bit of a stab in the dark. However, we had a failed Ruby
build with the following message:
```console
1) Hyrax::FileSetCSVService when specifying terms and separator csv
Failure/Error:
::CSV.generate do |csv|
csv << terms.map do |term|
values = file_set.send(term)
values = values.respond_to?(:to_a) ? values.to_a : [values] # make sure we have an array
values.join(multi_value_separator)
end
end
NameError:
uninitialized constant CSV
```
What I suspect to be in play is that the corresponding spec does not
similarly namespace the `CSV` constant. The production ruby file uses
`::CSV` whereas the spec ruby file uses `CSV`. This commit seeks to use
the same namespacing, hopefully reducing an intermittent error.
See the following CircleCI build for the failures:
- https://circleci.com/gh/samvera/hyrax/17063#tests/containers/3
jcoyne
approved these changes
Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x-stablebranchThese two commits, which don't effect the production version of Hyrax, do impact the test suite for Hyrax development on the
2.x-stablebranch.@samvera/hyrax-code-reviewers