Copy dist directory instead of uv directory #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
changed the title
yarn fails
jeremyf
previously approved these changes
Apr 23, 2020
when engine cart fails, don't silently move on. instead, blow up so folks can see what's going on.
The current build (3.0.36) of 3.0.x UV in NPM does not have a uv directory and the copy fails. It does have a dist directory so let's try copying that instead.
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when engine cart fails, don't silently move on. instead, blow up so folks can
see what's going on.
@samvera/hyrax-code-reviewers